Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have expenses page links direct to correct filters #5801

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Have expenses page links direct to correct filters #5801

merged 1 commit into from
Oct 13, 2021

Conversation

yuwenmemon
Copy link
Contributor

Pullerbearing ()
cc @tgolen

Details

Update the URL params to direct the "View all receipts" link to the expenses page with the correct filters turned on.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180928

Tests

  1. Go to NewDot and create a workspace
  2. Click on the reimburse receipts page
  3. Then click view all receipts to be redirected to OldDot
  4. Make sure that you see the correct policy selected in the Policy selector, the reimbursable/billable switch set to reimbursable, and the Submitter dropdown set to "All Submitters"

Screen Shot 2021-10-12 at 8 38 12 PM

@yuwenmemon yuwenmemon requested a review from a team October 13, 2021 03:47
@yuwenmemon yuwenmemon self-assigned this Oct 13, 2021
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team October 13, 2021 03:47
MariaHCD
MariaHCD approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well!

@MariaHCD MariaHCD merged commit c6570c9 into main Oct 13, 2021
@MariaHCD MariaHCD deleted the yuwen-betterLinks branch October 13, 2021 06:36
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@yuwenmemon yuwenmemon mentioned this pull request Oct 13, 2021
Merged
5 tasks
@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MariaHCD in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaHCD MariaHCD MariaHCD approved these changes

Assignees

@yuwenmemon yuwenmemon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwenmemon @OSBotify @MariaHCD